Add sound effects - Githubissues

Polprzewodnikowy / N64FlashcartMenu

Universal N64 flashcart menu for wide variety of devices

106 stars 7 forks source link

Add sound effects #108

Closed Suprapote closed 1 month ago

Suprapote commented 1 month ago

Description

Adding sound for make the navigation not so borring.

Motivation and Context

This issue

How Has This Been Tested?

Screenshots

https://github.com/Polprzewodnikowy/N64FlashcartMenu/assets/111246491/0f8086f6-16b3-4adb-a925-afbfc9fa6ba9

Types of changes

[x] Improvement (non-breaking change that adds a new feature)
[ ] Bug fix (fixes an issue)
[ ] Breaking change (breaking change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Signed-off-by: GITHUB_USER

Suprapote commented 1 month ago

PD: I changed the cursor sound

Suprapote commented 1 month ago

I extracted the sounds from the web that networkfusion recommended. I readed the rules and apparently all sounds in that page are free. If you want to check it out: https://pixabay.com/es/service/license-summary/

networkfusion commented 1 month ago

Nice work. I would suggest also updating the readme with the "notable feature" list and adding the source of the wav files (and their names/creator) to the "Open source software and licenses used" list.

networkfusion commented 1 month ago

I have been messing around with this, but not tested... My current state is https://github.com/networkfusion/N64FlashcartMenu/tree/refactor-sfx. Feel free to use it!

networkfusion commented 1 month ago

@Suprapote here are a few more changes to complete the refactor: https://github.com/Suprapote/N64FlashcartMenu/pull/1

Suprapote commented 1 month ago

I deleted the last two because I extracted them from the actions sound

networkfusion commented 1 month ago

I deleted the last two because I extracted them from the actions sound

In that case, probably better to update the action sound entry to state it is also for the other ones used.

networkfusion commented 1 month ago

I deleted the last two because I extracted them from the actions sound

In that case, probably better to update the action sound entry to state it is also for the other ones used.

Actually, after re-reading, probably fine.

networkfusion commented 1 month ago

Okay, I think I have done all I can to help with this PR 😅 . Hopefully my help has been useful and it helps understanding of the codebase and what is expected by your many future PR's @Suprapote 😁 .

Suprapote commented 1 month ago

Yes, thank you for your help 😁

Suprapote commented 1 month ago

Final result:

https://github.com/Polprzewodnikowy/N64FlashcartMenu/assets/111246491/d13c0d91-d8d6-4fb6-9318-82741927d020