Settings context menu - Githubissues

networkfusion commented 3 months ago

Description

Adds ability to set the config.ini settings from the menu.

Motivation and Context

Ability to set the settings was missing from the menu.

How Has This Been Tested?

Tested on an SC64.

Screenshots

Types of changes

[x] Improvement (non-breaking change that adds a new feature)
[ ] Bug fix (fixes an issue)
[ ] Breaking change (breaking change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Signed-off-by: GITHUB_USER

IlDucci commented 3 months ago

This submenu looks great, do you think it could use a bit of simplification?

There are two different phrases for the usage of the A Button. Maybe you could remove the first line and change the A text hint at the bottom to, for example, "A: Save and Exit Menu".
Maybe the first asterisk is superfluous. If there are two different places where you can change the default directory, you could either try to avoid having the two sources of change and put everything into a single place or simply remove that extra information.

networkfusion commented 3 months ago

This submenu looks great, do you think it could use a bit of simplification?

* There are two different phrases for the usage of the A Button. Maybe you could remove the first line and change the A text hint at the bottom to, for example, "A: Save and Exit Menu".

* Maybe the first asterisk is superfluous. If there are two different places where you can change the default directory, you could either try to avoid having the two sources of change and put everything into a single place or simply remove that extra information.

IMO, when actually using the menu, the context of A is more intuatitive than all other alternatives I have attempted. But given that all changes are auto saved when you change them, there is no point in displaying a "Save and exit".

I kinda agree that the asterisk's should not be there, but they can be removed at a later date, once we can fix the issue with SFX needing a restart and a better way to show read only options.

This PR was (for the moment) only trying to reach the develop branch, since it requires the SFX anyway, but could be merged with main, since it will sill work.

Polprzewodnikowy / N64FlashcartMenu