search

Polprzewodnikowy / N64FlashcartMenu

Universal N64 flashcart menu for wide variety of devices
156 stars 14 forks source link

Revert PAL60 change to workaround HW incompatibilities #163

Open FazanaJ opened 2 days ago

FazanaJ commented 2 days ago

Description

Changes the way PAL60 is handled back to the old method, as seen on the stable release.

Motivation and Context

The N64Digital hardware mod does not work with the inbuilt PAL60 VI mode libdragon offers. It's not known currently if other HDMI mods work with this VI mode.

How Has This Been Tested?

Made the changes and ran on my system, with the setting on and off.

Screenshots

Types of changes

Checklist:

Signed-off-by: FazanaJ

coderabbitai[bot] commented 2 days ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
networkfusion commented 2 days ago

I am happy to revert but the question becomes that we need to test these scenarios:

backtrace: https://discordapp.com/channels/205520502922543113/1262536014623146125/1285662891781001279

And locate the original PR/commit that the change was introduced. https://github.com/Polprzewodnikowy/N64FlashcartMenu/commit/10a8fcab9e2231b9fa2fb9e7bbd48bd4a96fe475

riggles1 commented 2 days ago

I am happy to revert but the question becomes that we need to test these scenarios:

  • RGB Mod (PAL console).
  • HDMI Mod (PAL console).
  • Stock MPAL console.

There's another scenario, that's a crystal modded PAL system, so x1 crystal speed matches that of the NTSC units, generating an in-spec NTSC speed rather than the 2% off PAL60 speed.

PIF is still PAL-region of course, composite will be NTSC colored proper NTSC speed, RGB mods like eTim's board work like normal ontop of that. N64_60Hz_Mod_Guide

networkfusion commented 2 days ago

@FazanaJ I am wondering your thoughts on something like this: https://github.com/networkfusion/N64FlashcartMenu/commit/991739a1fdf28f2604df4a70193bfe5344f2c020

FazanaJ commented 2 days ago

I'm personally more than fine with this too. Definitely worth an opinion check with others though, since it could potentially border on a little bloat.

networkfusion commented 2 days ago

I'm personally more than fine with this too. Definitely worth an opinion check with others though, since it could potentially border on a little bloat.

I am thinking that it covers @riggles1 comment (as might be the issue you are experiencing anyway). Feel free to test and merge into this PR.

networkfusion commented 2 days ago

I have updated my branch source with regard to the new info: #165 Currently tested on an Ultra HDMI modded PAL console using both HDMI and its analogue output.