Polprzewodnikowy / N64FlashcartMenu

Universal N64 flashcart menu for wide variety of devices
106 stars 7 forks source link

other saves extensions #90

Closed Suprapote closed 5 months ago

Suprapote commented 5 months ago

I made these changes to make more easier to move the savefiles between OSs

Suprapote commented 5 months ago

is there any function that can help me or you got a tip of how to make the save check?

networkfusion commented 5 months ago

IMHO, what "should" happen, is that the save types and required conversions are added as documentation as stated in https://github.com/Polprzewodnikowy/N64FlashcartMenu/issues/76

But, It would be nice to convert the "initial" load from the SD card file. It is more than likely that in most cases, (if coming from an ED64) the file just needs to be renamed (e.g. fla to sav) and it would be handled. If not, it is probably byte swapped.

Polprzewodnikowy commented 5 months ago

Did any of the ED64 menus (official or not) operate with byte swapped save files? I'm not sure if it's even necessary to do any conversion other than file extension change. Save files are just flat binaries, this menu assumes everything is saved as big endian files - native to the N64.

Polprzewodnikowy commented 5 months ago

is there any function that can help me or you got a tip of how to make the save check?

Look at this function: https://github.com/Polprzewodnikowy/N64FlashcartMenu/blob/main/src/utils/fs.c#L23-L30

networkfusion commented 5 months ago

Did any of the ED64 menus (official or not) operate with byte swapped save files? I'm not sure if it's even necessary to do any conversion other than file extension change. Save files are just flat binaries, this menu assumes everything is saved as big endian files - native to the N64.

I am quite sure they are not byte swapped for the ED64, and are handled the same as this "menu", especially given people come from certain emulators and expect them to work OTB and dont.

Here is a number of save files that have been "proved working" on the ED64: https://krikzz.com/forum/index.php?topic=1093.0

TharathielCB commented 5 months ago

Changing the extension to .sav worked for ed64p (altra) and everdrive x7

networkfusion commented 5 months ago

This should go some way towards what is wanted... https://github.com/Polprzewodnikowy/N64FlashcartMenu/compare/main...networkfusion:N64FlashcartMenu:improve-savetype-alt