PolyChord / PolyChordLite

Public version of PolyChord: See polychord.co.uk for PolyChordPro
https://polychord.io/
Other
84 stars 26 forks source link

Edited process for creating output directories to avoid race condition #18

Closed dominicanstey closed 5 years ago

dominicanstey commented 5 years ago

Changed the process for making output directories to a 'try/except', to avoid the race condition created by the 'if not' process

williamjameshandley commented 5 years ago

Hi @dominicanstey

Unfortunately the tests are showing that whilst this fixes the race condition for the MPI case, it breaks for the non-mpi case.

Do you need the conditional statement now? Couldn't you just run os.makedirs on all cores regardless of rank in this setup?

You should also specify that you're catching the OSError exception, rather than a generic one.

williamjameshandley commented 5 years ago

@dominicanstey any update on the above?