PolyChord / PolyChordLite

Public version of PolyChord: See polychord.co.uk for PolyChordPro
https://polychord.io/
Other
84 stars 26 forks source link

[WIP] Build system changes to allow pip installation from source #19

Closed tilmantroester closed 5 years ago

tilmantroester commented 5 years ago

This PR attempts to unify the build process such that a single python setup.py install builds and installs the whole library. Ditto for pip. To accomplish this, libchord.so is now being compiled at the build_py step (for stupid, setuptools-related reasons) and then copied into the package. The extension is compiled with the right rpath, $ORIGIN, and install_name settings so that things work. Getting this to work cost me a good chunk of my sanity and will probably leave me with setuptools related PTSD for the foreseeable future.

To summarise:

This should probably be tested in more detail. At the moment it is based of the setup_pip branch but I think it could easily be rebased to master.

williamjameshandley commented 5 years ago

Potentially fixes #13 and #11

tilmantroester commented 5 years ago

Should be replaced by PR #24.