Polycord crashes Cobaya with large numbers of clusters

PolyChord / PolyChordLite

Public version of PolyChord: See polychord.co.uk for PolyChordPro

https://polychord.io/

Other

83 stars 26 forks source link

Polycord crashes Cobaya with large numbers of clusters #71

Closed Skipp1 closed 2 years ago

Skipp1 commented 2 years ago

When Polychord has more than 100 clusters, Cobaya crashes. This is because Polychord formats its output as:

...
log(Z_98)
log(Z_99)
log(Z_**) 
log(Z_**)
...

Due to this formatting Cobaya crashes trying to convert the string "**" to an int() on line 345 of cobaya/samplers/polychord/polychord.py

I have opened an issue with the Cobaya team and have been told to come here https://github.com/CobayaSampler/cobaya/issues/190

williamjameshandley commented 2 years ago

Hi @Skipp1. This has been a bug I've been meaning to fix for a while, but the intricacies of Fortran's string manipulation meant I needed a little push.

Could you check if you install polychord from the branch large_cluster_fix that this resolves your issue?

Skipp1 commented 2 years ago

Yes the large_cluster_fix branch solves all the issues, Thanks