Pass custom mpi4py communicator - Githubissues

PolyChord / PolyChordLite

Public version of PolyChord: See polychord.co.uk for PolyChordPro

https://polychord.io/

Other

84 stars 26 forks source link

Pass custom mpi4py communicator #93

Open adematti opened 1 year ago

adematti commented 1 year ago

Hi, Thanks for this sampler! Here are two suggestions:

it'd be nice to be able to provide, through the Python wrapper, the proper mpi4py communicator in case it is not COMM_WORLD (e.g. to have several runs in parallel).
it may be worth avoiding MPI_ANY_TAG, e.g. in https://github.com/PolyChord/PolyChordLite/blob/e00386ba83766ea04365c055b5f17d6f62c0ee04/src/polychord/mpi_utils.F90#L492, which may conflict with potential MPI communication between e.g. the user-provided logposterior and dumper.

I have a branch that addresses the above suggestions I think, here: https://github.com/adematti/PolyChordLite/tree/mpi4py (I can file a PR if desired) Best

williamjameshandley commented 1 year ago

Hi @adematti. Both of these sound like a great idea. Feel free to file a PR.