search

PolyJIT / benchbuild

Empirical-Research Toolkit
MIT License
11 stars 12 forks source link

Fixes buildah mount to install BB from source #482

Closed vulder closed 2 years ago

vulder commented 2 years ago

With newer buildah versions the default for mounts becomes/is read only. Hence, we need to specify should need to write to the mount, as in the case with installing BB from source (this creates and writes egg files).

codecov[bot] commented 2 years ago

Codecov Report

Merging #482 (1192c91) into master (207fba5) will decrease coverage by 0.03%. The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   52.52%   52.49%   -0.04%     
==========================================
  Files         123      123              
  Lines        7762     7771       +9     
  Branches     1210     1211       +1     
==========================================
+ Hits         4077     4079       +2     
- Misses       3511     3518       +7     
  Partials      174      174
Impacted Files Coverage Δ
benchbuild/environments/adapters/common.py 60.00% <20.00%> (-3.64%) :arrow_down:
benchbuild/environments/domain/declarative.py 74.19% <25.00%> (-3.40%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 207fba5...1192c91. Read the comment docs.