Open fel1x0u opened 3 years ago
Have you tried to run your code? I checked your repository and it doesn’t contain a data folder. This should not be merged.
Also: why did you first delete everything?
On Mon, Mar 22, 2021 at 6:35 AM mandar1jn @.***> wrote: Also: why did you first delete everything?
?You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe. Because, I edited it on my PC. I used an external IDE
@fel1x0u what?
I edited the files on my local PC.
I get that, but why did you delete the file? You could have just forked it and then cloned the repo. I don’t see the need to delete all files. Also: what happened to the data folder?
On Wed, Mar 24, 2021 at 1:53 AM mandar1jn @.***> wrote:
I get that, but why did you delete the file? You could have just forked it and then cloned the repo. I don?t see the need to delete all files. Also: what happened to the data folder?
?You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
I forgot to upload it. Let me fix that
On Mon, Mar 22, 2021 at 6:35 AM mandar1jn @.***> wrote: Also: why did you first delete everything? ?You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe. Because, I edited it on my PC. I used an external IDE
If PolyMars accepts this the game would literally break, I think you should update main close this PR and create a new one.
If there is no data folder the game won't have audio, images and nothing of that sort. It would probably give anyone who tries playing 1000 errors.
Indeed
On Wed, Mar 24, 2021 at 1:53 AM mandar1jn @.***> wrote: I get that, but why did you delete the file? You could have just forked it and then cloned the repo. I don?t see the need to delete all files. Also: what happened to the data folder? ?You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe. I forgot to upload it. Let me fix that
I get that, but that is still no answer to my question. Why didn’t you just clone the repository?
Okay, okay! Please just let me have time my upload speed is like 2 mpbs
okay done
@fel1x0u I still want an answer. Why did you delete all the files instead of cloning the repo?
@mandar1jn He literally said: he forgot to upload.
I know that doesn't make sense, but he's probably never used git
before.
brrrrrr does markdown even work ééééééééééééééééééééééééééééééééééééééé
@firefish111 I get what you mean, but the thing I am wondering is why he deleted all the files first.
I already said so................................ because I edited it from my PC
From: mandar1jn @.> Sent: Thursday, April 15, 2021 8:01 AM To: PolyMarsDev/Flappuccino @.> Cc: fel1x0u @.>; Mention @.> Subject: Re: [PolyMarsDev/Flappuccino] Fixed up the files (#13)
@firefish111https://github.com/firefish111 I get what you mean, but the thing I am wondering is why he deleted all the files first.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PolyMarsDev/Flappuccino/pull/13#issuecomment-820499747, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARR6QUKDX5TJ4IVYQEQMTO3TI35V3ANCNFSM4ZLGE4IQ.
@fel1x0u You could've done git checkout
then git push
... or at least i think that's how it works
I don't use git.
From: Fire Fish @.> Sent: Thursday, April 15, 2021 2:23 PM To: PolyMarsDev/Flappuccino @.> Cc: fel1x0u @.>; Mention @.> Subject: Re: [PolyMarsDev/Flappuccino] Fixed up the files (#13)
@fel1x0uhttps://github.com/fel1x0u You could've done git checkout then git push... or at least i think that's how it works
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PolyMarsDev/Flappuccino/pull/13#issuecomment-820740160, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARR6QULM5STVITPFOGDIL4TTI5KMFANCNFSM4ZLGE4IQ.
@fel1x0u Well... how did you make a pull request if you don't use git?
Are you an idiot?
I used the one from GitHub.
From: Fire Fish @.> Sent: Friday, April 16, 2021 12:24 PM To: PolyMarsDev/Flappuccino @.> Cc: fel1x0u @.>; Mention @.> Subject: Re: [PolyMarsDev/Flappuccino] Fixed up the files (#13)
@fel1x0uhttps://github.com/fel1x0u Well... how did you make a pull request if you don't use git?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PolyMarsDev/Flappuccino/pull/13#issuecomment-821513168, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARR6QUO3BM43NDSCTMAR3WTTJCFFXANCNFSM4ZLGE4IQ.
@fel1x0u GitHub is a git repository hosting platform...
In my opinion #7 should be merged instead of this. It is cleaner and doesn’t have a lot of mentioned file changes that aren’t needed
Is this pull dead? I was cleaning my emails and came across this.
Is this pull dead? I was cleaning my emails and came across this.
Polymarsdev kinda just doesn’t check github
@mandar1jn i'd know, it took around a month to reply to the bean on the left plus on the right thingo
@firefish111 I have pull requests on his repositories that are almost a year old
Okay. I have updated some of the code and made the code easier to understand, according to PyCharm IDE.