justinlangley3
commented
2 years ago The imports are not setup correctly in this project.
It tends poor usage in Python to use relative imports unless you're adding them to the __init__.py file of a sub-package to resolve broken imports. Otherwise you'll probably end up with that import error or the infamous circular import error.
Please Reference: PEP 8 - Imports
In the example @BOXEL-REBOUND provides of Line 5 it's the incorrect way to import:
from .player import Player
The imports from other project files should look like this (following PEP 8 style conventions):
from background import Background
from bean import Bean
from button import Button
from player import Player
from utils import clamp, check_collisionsAnother thing to note is there are other imports in this project that break PEP 8 style conventions. For example (incorrect):
import colorsys, math, random, sys, timeFollowing PEP 8 style conventions (correct):
import colorsys
import math
import random
import sys
import timeThe rule is one import per line, and the only exception is multiple imports from a package or sub-package, as seen above:
from utils import clamp, check_collisionsOne more PEP 8 violation I saw a lot of in this project follows up on the last example:
In the utils package, there is a function named checkCollisions, but it should be named check_collisions to follow python's naming convention guidelines. In that same file there is another violation where the reserved keywords min, max are used as parameters to the clamp function.
Please Reference: PEP 8 - Naming Conventions
sq3kk
nigamanthsrivatsan
CaptainChicky
bigbuny
When I run it, the terminal says Import Error. Here's the total error:
Traceback (most recent call last): File "c:\Users\dacpu\OneDrive\Desktop\Flappuccino\main.py", line 5, in
from .player import Player
ImportError: attempted relative import with no known parent package
I have every file, and it is not just this import, it is all of them.