search

PolyMarsDev / Sokobot

A Discord bot that lets you play Sokoban
254 stars 135 forks source link

Added some optimization #38

Closed mandar1jn closed 1 month ago

mandar1jn commented 3 years ago

In CommandEvent.java there were 2 if statements right after each other that were the same. And I switched some if statements to a switch statement (get it?)

mandar1jn commented 3 years ago

I love how this pull request has been up since 27 November and still hasn’t been merged/denied

a-gt commented 3 years ago

Lol

kk5dire commented 3 years ago

@mandar1jn

I love how this pull request has been up since 27 November and still hasn’t been merged/denied

lol i just read this cant you just ask someone who commits to the repo

mandar1jn commented 3 years ago

@kk5dire nope. He doesn’t check his github. @PolyMarsDev Here. I pinged him. I bet he won’t do anything with this for another 2 years. Around 2 months ago I exposed him in a Q&A. He promised to go check out his github repositories. Well, I have pull requests in almost all of his repositories and none have been merged or denied

AffluentAvo commented 3 years ago

I could merge them, however I do not maintain the public bots anymore and I am not sure what PolyMars would like to do with the code or if he would approve the merge. I will contact him to check this out.

mandar1jn commented 3 years ago

@AffluentAvo thanks!

kk5dire commented 3 years ago

@T0biii ?

yes?

oh I got confused by the random issue mention, for some reason I thought it meant you mentioned an issue here

T0biii commented 3 years ago

@T0biii ?

yes?

oh I got confused by the random issue mention, for some reason I thought it meant you mentioned an issue here

in the Issue i mention this Pull Requests because of the erros he get. Because one commit here fixed the encoding for the MYSQL PW

mandar1jn commented 3 years ago

@T0biii ?

yes?

oh I got confused by the random issue mention, for some reason I thought it meant you mentioned an issue here

in the Issue i mention this Pull Requests because of the erros he get. Because one commit here fixed the encoding for the MYSQL PW

I fixed it not because it’s broken in the main repo, but because the program I used encoded it wrong.