search

PolyMathOrg / DataFrame

DataFrame in Pharo - tabular data structures for data analysis
MIT License
74 stars 29 forks source link

DataFrame references the missing class AIMissingCategory #251

Open olekscode opened 1 year ago

olekscode commented 1 year ago

This method requires pharo-ai to be loaded into the image Which is strange because DataFrame should not depend on AI So we need to check, maybe it's the method that was accidentally committed here

dataPreProcessingEncodeWith: anEncoder
    "This method is here to speed up pharo-ai/data-preprocessing algos without coupling both projects."

    | copy cache |
    copy := self copy.
    cache := IdentityDictionary new.
    self columns doWithIndex: [ :dataSerie :columnIndex |
        | category |
        category := cache at: columnIndex ifAbsentPut: [ ((anEncoder categories at: columnIndex) collectWithIndex: [ :elem :index | elem -> index ]) asDictionary ].
        dataSerie doWithIndex: [ :element :rowIndex |
            copy at: rowIndex at: columnIndex put: (category at: element ifAbsent: [ AIMissingCategory signalFor: element ]) ] ].

    ^ copy
jecisc commented 1 year ago

This is my fault indeed :)

I'll add to my todo list to fix this.

olekscode commented 6 months ago

This method should be moved to https://github.com/pharo-ai/data-preprocessing and removed from this repository