search

PolyMeilex / rfd

Rusty File Dialog
MIT License
564 stars 64 forks source link

async-executor v1.5.2 breaks the build #136

Closed uklotzde closed 1 year ago

uklotzde commented 1 year ago 
error: future cannot be sent between threads safely
   --> /home/uk/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rfd-0.11.4/src/backend/xdg_desktop_portal.rs:43:9
    |
43  | /         Box::pin(async {
44  | |             OpenFileRequest::default()
45  | |                 .accept_label("Pick file")
46  | |                 .multiple(false)
...   |
59  | |                 .map(FileHandle::from)
60  | |         })
    | |__________^ future created by async block is not `Send`
    |
    = help: within `[async block@/home/uk/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rfd-0.11.4/src/backend/xdg_desktop_portal.rs:43:18: 60:10]`, the trait `std::marker::Send` is not implemented for `*const async_executor::State`

...and more...

PolyMeilex commented 1 year ago

Thanks! The async-executor 1.5.2 got yanked (smol-rs/async-executor/issues/49), so we should be safe for now.

Will keep this open for now until the situation in async-executor issue is more clear.

uklotzde commented 1 year ago

We could close this issue if the async-executor release contained unintended, breaking changes.