search

PolyMeilex / sctk-adwaita

Adwaita-like SCTK Frame
MIT License
26 stars 19 forks source link

Also query `org.gnome.desktop.interface color-scheme` for `auto` theme #23

Open kchibisov opened 1 year ago

kchibisov commented 1 year ago

Right now the portal is used, but there's also a gnome specific thing https://github.com/GNOME/gsettings-desktop-schemas/blob/98ee09e0a7d1ce99a462eee4c26f51bc497c4d49/schemas/org.gnome.desktop.interface.gschema.xml.in#L297 .

PolyMeilex commented 1 year ago

What is the value of using Gnome specific setting if Gnome supports and prefers the existing standard anyway?

We had it implemented already here, but I'm not a huge fan of hard-coding Gnome specific stuff, so it was intentionally replaced with non-gnome specific solution, aka XDG settings portal.

Not opposed to adding it back, I just don't see a point.

kchibisov commented 1 year ago

We had it implemented already here, but I'm not a huge fan of hard-coding Gnome specific stuff, so it was intentionally replaced with non-gnome specific solution, aka XDG settings portal.

Mostly as a fallback to portal, I don't have portals at all for example, but have gnome stuff to configure gtk and set preferred theme there. I'm not sure you can be on GNOME without a portal though.

orowith2os commented 1 year ago

There's no benefit to using GNOME-specific interfaces when cross-desktop standards exist already.

If a desktop doesn't have a portal exposing basic preferences such as these, then imo it's broken.

I'm not sure you can be on GNOME without a portal though.

No, not without a very broken user experience.