search

PolyMeilex / sctk-adwaita

Adwaita-like SCTK Frame
MIT License
26 stars 19 forks source link

Crash in ab_glyph renderer #63

Closed Friz64 closed 2 months ago

Friz64 commented 2 months ago

See https://github.com/pop-os/cosmic-files/issues/241

Haven't tried to reproduce it yet.

PolyMeilex commented 2 months ago

It's the second time this code path panics, I think I will just make it ignore out of range pixels, better to have weirdly cropped text rather than panic on every weird edge case.

PolyMeilex commented 2 months ago

Althou now, that I'm looking at the report, even cosmic-text can't load that font up, so maybe it's not even ab-glyphs fault: 

[2024-06-12T07:05:52Z WARN  cosmic_text::font::system] failed to load font 'SymbolsNFM'
Friz64 commented 2 months ago

Hm, but he also said "It can show Chinese text correctly", so maybe it's an unimportant warning?

Regardless of that, I think your fix is for the better.

PolyMeilex commented 2 months ago

Published 0.10.1, 0.9.1, and 0.8.3 so it should be fine now, I believe cosmic-files is on 0.8 so cargo update should do the trick.