search

PolyPhyHub / PolyPhy

Main repository of the PolyPhy package
https://polyphy.io
MIT License
35 stars 19 forks source link

Make simulation margin a command line argument #75

Closed OskarElek closed 3 months ago

OskarElek commented 9 months ago

The discrete 2D and 3D pipeline add a margin into the simulation domain (reflected in the trace and deposit solutions).

This margin is a parameter hardcoded in the common.py->PPConfig class as DOMAIN_MARGIN parameter. This should be configurable from the CLI as an argument to polyphy.

Abhinavcode13 commented 8 months ago

Is the directory is src/ployphy -> Core -> common.py ? @OskarElek

OskarElek commented 8 months ago

Yes @Abhinavcode13 that's correct.

In general there's an existing pipeline for parsing cmd arguments and setting them in the specific instance of PPConfig. This is implemented in utils/cli_helper.py so that's a natural place to add the functionality.

Testing can then be done in any of the pipelines, the 2D Discrete one would be the simplest to do so.