frame_max error, heartbeat left when closing

Polyconseil / aioamqp

AMQP implementation using asyncio

Other

280 stars 88 forks source link

frame_max error, heartbeat left when closing #108

Closed smurfix closed 7 years ago

smurfix commented 8 years ago

Two patches here:

if the server reports a max frame of zero (some do: should be interpreted as "don't care"), aioamqp stops working. I think I already submitted that..? anyway it's still needed.
When closing the protocol, sometimes the heartbeat timers are left running, which leads to spurious error messages later. This patch cancels them and prevents them from restarting.

smurfix commented 8 years ago

NB: I also see the Py3.5 results of the Travis test in production. I'll open an issue for it.

RemiCardona commented 8 years ago

The first one is a really good catch!

As for the second one, I didn't look too much at framing in the AMQP spec, @dzen did all the work there. I'll have to look it up. And indeed, it looks like you already sent that patch in #103.

Hopefully, I'll get around to that really soon. Thanks for both patches!

Cheers

RemiCardona commented 7 years ago

Both patches merged. Thanks for the contribution and your patience!

Cheers