Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

protocol on_error called twice for the same issue #124

Open progovoy opened 7 years ago

progovoy commented 7 years ago

Steps to reproduce on aioamqp 0.8.2:

Did not investigated it but, this happens because _close_channels in protocol.py is called on connection lost and on AmqpClosedConncetion exception.

Desired behavior: on connection error I would expect my callback to be called once to be able to handle reconnection properly.

RemiCardona commented 7 years ago

This will be dealt with as part of the API redesign of #118. This callback (like most/all others) is most likely going to be removed altogether.