Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Adds External authentication (over SSL) #132

Closed pdyba closed 5 years ago

dzen commented 7 years ago

hello @pdyba !

Thanks for this awesome contribution. I think we should provides some tests with a fworking PKI to ensure a non regression test ?

dzen commented 5 years ago

Hello @pdyba. There was some enhancement in the API a few days ago : connect and from_url now accept a SSLContext object to configure the SSL connection.

So this PR is probably not required isn't it ? You can now pass a Configured SSLContext object, and set login_method to EXTERNAL.