search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Updated AmqpEncoder #156

Closed MegaDiablo closed 6 years ago

MegaDiablo commented 6 years ago

Added support of array, datetime, float, decimal and None value. Added converting timestamp to datetime

dzen commented 6 years ago

Hello @MegaDiablo.

Thank you for this PR. It's right, we're missing the field-array frame type.

Since the code looks okay, would you please add a test ? Furthermore we probably want to have the AmqpDecoder class to implement such fonctionnality haven't we ?

MegaDiablo commented 6 years ago

Hi @dzen.

Class AmqpDecoder have support field-array frame type. (https://github.com/Polyconseil/aioamqp/blob/master/aioamqp/frame.py#L321)

dzen commented 6 years ago

Woops, sorry :D

MegaDiablo commented 6 years ago

Hi @dzen

Look this upgrade of AmqpEncoder. In AmqpDecoder all this types was implimented before me

RemiCardona commented 6 years ago

@MegaDiablo thanks a lot for your PR, it's greatly appreciated!

Cheers