Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Add support for Basic.Return #158

Closed nhumrich closed 6 years ago

nhumrich commented 6 years ago

Fixes #140

nhumrich commented 6 years ago

Bump. Any word on this? Can this get merged, or can we at least have a discussion about it?

Relrin commented 6 years ago

@dzen @RemiCardona Any plans to merge this PR ?

dzen commented 6 years ago

@nhumrich Hello. Sorry for the very late aswer. We have a few comments on this PR but we're open to this !

nhumrich commented 6 years ago

Added test, and rebased onto master

nhumrich commented 6 years ago

Sounds good to me. Updated.

nhumrich commented 6 years ago

Updated. Fixed test and example.

dzen commented 6 years ago

thanks ! will merge soon !

dzen commented 6 years ago

Thanks for your contribution. I added your name in the authors file.