search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

performance optimization #162

Closed gescheit closed 2 years ago

gescheit commented 6 years ago

Hi! I had rewritten work with heartbeat because old one was very heavy due creating/canceling heartbeat coros.

RemiCardona commented 6 years ago

@gescheit thanks for this PR (and thanks to @EvaSDK for reviewing it).

I am worried about the state of commits though, there's a lot going on, spread over many commits, with some gratuitous whitespace changes.

I'll read over this PR soon to suggest changes (and/or commit them directly if they are simple enough)

Thanks

gescheit commented 6 years ago

Any news?

dzen commented 6 years ago

I would appreciate if you split up this PR in at most 3 to enlight:

RemiCardona commented 2 years ago

Closing in favor of #234.