search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

AMQP 1.0.0 #173

Open terricain opened 6 years ago

terricain commented 6 years ago

I have a need for v1.0.0 (sadly I have a requirement to use ActiveMQ and am using STOMP atm :/)

I've got a really simple example I hacked up that currently connects, sends a header packet and does SASL login.

Once I've implemented enough for some basic produce/consume, how woud I go about PRing this considering v1.0.0 is drastically different to v0.9.1

dzen commented 6 years ago

Hello @terrycain,

I did'nt read any specs about AMQP 1.0. When implementing a first version, I was focused on 0.9.1. Feel free to start a PR, and explain how you would go for a first version ?

In a first try, I would like to focus on the API :)

gmr commented 5 years ago

AMQP 1.0 is a different beast all-together. You'd probably be better off making an aioamqp1 as a separate library given the foundational differences. It's not an evolution of the 0.x AMQP protocol.

dzen commented 5 years ago

Hello @gmr, thanks for also having a look on this project ;)

the lib can also have two endpoints, depending on the selection of the desired protocol. Plus, since we now depends on pamp for the protocol layer, it would be a nice addition to pamqp wouldn't be ?