Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Separate waiters for 'basic_cancel' #207

Closed ice2heart closed 2 years ago

ice2heart commented 4 years ago

How to reproduce problem.

  1. Open 2 queue to consuming
  2. Close them in the same time
  3. Catch "aioamqp.exceptions.SynchronizationError: Waiter already exists"
ice2heart commented 4 years ago

I checked tests locally, no problem. I think the travis config is broken.

dzen commented 4 years ago

Hello @ice2heart,

your commit seems right.

It seems that travis does not run rabbit's management interface, which we rely on to create / drop vhosts when running tests.

dzen commented 4 years ago

I just fixed travis install. Rabbitmq was not installed by default. Would you please squash your commits and rebase onto master ?

ice2heart commented 4 years ago

Still have some problem with test. I checked and it looks like a rabbit communication problem.

dzen commented 4 years ago

There is one test left, which depends on the rabbitmq version AFAIK

It's not your fault ;) the same problem occurs on master. I have no time this week to dig in.

On Fri, Aug 23, 2019 at 1:22 PM Ice2heart notifications@github.com wrote:

Still have some problem with test. I checked and it looks like a rabbit communication problem.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Polyconseil/aioamqp/pull/207?email_source=notifications&email_token=AAAMIQI3BHMWZ3H4O47AEVDQF7B6TA5CNFSM4INUOFXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD475XNY#issuecomment-524278711, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAMIQKZUW2YRU5R5WJ6DB3QF7B6TANCNFSM4INUOFXA .

-- Benoît CALVEZ Polyconseil | 26 rue de Berri | 75008 Paris

ice2heart commented 4 years ago

@dzen we finaly can merge this code.

RemiCardona commented 2 years ago

Just got around to merging this, thanks again for your PR, it is very much appreciated.

Thanks again for your patience. Cheers.