Closed ice2heart closed 2 years ago
I checked tests locally, no problem. I think the travis config is broken.
Hello @ice2heart,
your commit seems right.
It seems that travis does not run rabbit's management interface, which we rely on to create / drop vhosts when running tests.
I just fixed travis install. Rabbitmq was not installed by default. Would you please squash your commits and rebase onto master ?
Still have some problem with test. I checked and it looks like a rabbit communication problem.
There is one test left, which depends on the rabbitmq version AFAIK
It's not your fault ;) the same problem occurs on master. I have no time this week to dig in.
On Fri, Aug 23, 2019 at 1:22 PM Ice2heart notifications@github.com wrote:
Still have some problem with test. I checked and it looks like a rabbit communication problem.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Polyconseil/aioamqp/pull/207?email_source=notifications&email_token=AAAMIQI3BHMWZ3H4O47AEVDQF7B6TA5CNFSM4INUOFXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD475XNY#issuecomment-524278711, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAMIQKZUW2YRU5R5WJ6DB3QF7B6TANCNFSM4INUOFXA .
-- Benoît CALVEZ Polyconseil | 26 rue de Berri | 75008 Paris
@dzen we finaly can merge this code.
Just got around to merging this, thanks again for your PR, it is very much appreciated.
Thanks again for your patience. Cheers.
How to reproduce problem.