search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Python 3.8 support #211

Closed fullylegit closed 4 years ago

fullylegit commented 4 years ago

In python 3.8 the StreamReader within the StreamReaderProtocol has been changed to a weakref. We have to keep a strong ref to the StreamReader in scope for the lifetime of the AmqpProtocol.

Polyconseil/aioamqp#210

michael-k commented 4 years ago

Can you also update .travis.yml and tox.ini? If this is the only thing broken in combination with Python 3.8, updating setup.py (classifiers) and setup.cfg (bdist_wheel) would be nice. :)

fullylegit commented 4 years ago

Added 3.8 to travis, tox and setup files.

The StreamReader change is the only thing I've found that's broken in 3.8, however there are some deprecation warnings coming from the use of the loop= parameter in a number of asyncio functions due to bpo-36373.

I haven't done anything about them and am unsure whether to leave them as-is for the moment and deal with them pre-py3.10 or remove the param now. Appreciate others' thoughts.

GamePad64 commented 4 years ago

@dzen Could you please release this patch to pypi? This fix is the only thing that keeps us from moving to Python 3.8 (and we don't want to use git packages).

dzen commented 4 years ago

Le mar. 19 nov. 2019 à 17:39, Alexander Shishenko notifications@github.com a écrit :

@dzen https://github.com/dzen Could you please release this patch to pypi? This fix is the only thing that keeps us from moving to Python 3.8 (and we don't want to use git packages)

Sure, tomorrow morning

.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Polyconseil/aioamqp/pull/211?email_source=notifications&email_token=AAAMIQMWCL36B6T5OTYH7R3QUQJCVA5CNFSM4JNWZIA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEO3JAI#issuecomment-555594881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMIQIVC2WBZWWHJXRZ4UDQUQJCVANCNFSM4JNWZIAQ .

-- Benoît CALVEZ Polyconseil | 26 rue de Berri | 75008 Paris