search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Fix broken test test_wrong_parameter_queue #212

Closed fullylegit closed 2 years ago

fullylegit commented 4 years ago

Changed the expected error code to 405 or 406 (depends on the rabbitmq version)

The test was broken due to a rabbitmq change: rabbitmq/rabbitmq-server#1888 The exclusiveness check (which generates a 405) has been moved to before the argument equality check (which generates a 406).

Additionally fixed the travis build by changing to bionic. There is a bug in the latest rabbitmq version available on xenial that was being hit by test_queue_declare_custom_x_message_ttl_32_bits. The bug has been fixed in the version available on bionic.

dzen commented 4 years ago

Nice !

Please squash and I will rebase & merge

dzen commented 4 years ago

I'll merge as-is.

RemiCardona commented 2 years ago

Housekeeping: merged in commit d5ee4226. Closing.