search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Add support to ppc64le #223

Closed gururajrkatti closed 2 years ago

gururajrkatti commented 3 years ago

This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date. Since ppc64le focal doesn't have python 3.7 support, that is only excluded.

RemiCardona commented 3 years ago

There's no C code in aioamqp and — as per the AMQP spec — all the bytes mangling is based on fixed sizes, not architecture-specific ones (such as int or long). I just don't see the point. Care to elaborate why aioamqp needs this? Thanks

gururajrkatti commented 3 years ago

Hi @RemiCardona , thanks for your response and feedback, I understand your point. I agree that since there is no C code, it ideally should work on all architectures. However, in our past experience we have run into architecture specific issues even with pure python packages with their tests failing in some cases , mostly because of an indirect dependency on native code or libraries via other python dependencies. by enabling the travis support here, we are attempting to catch those issues early, hope that makes some sense? Adding @gerrith3 for more details

RemiCardona commented 2 years ago

Travis CI is dead (for FLOSS projects anyway) so this PR is outdated, and github actions doesn't seem to support any non-amd64 arches. So that settles the issue.