Channel.basic_server_ack doesn't respect `multiple` flag

Polyconseil / aioamqp

AMQP implementation using asyncio

Other

280 stars 88 forks source link

Channel.basic_server_ack doesn't respect `multiple` flag #233

Open alexchamberlain opened 2 years ago

alexchamberlain commented 2 years ago

When using publisher confirms, the broker may use the multiple flag to indicate that any delivery tag less than the one specified should be considered acknowledged, but that isn't being respected by basic_server_ack at the moment. This leads futures that are not resolved by the library.

RemiCardona commented 2 years ago

Just to be 100% sure, did you try this on 0.15.0b1? I don't remember merging anything related to acks but just in case…

alexchamberlain commented 2 years ago

I did not, but the latest code on master doesn't refer to frame.multiple, so I don't think it's handled.

RemiCardona commented 2 years ago

I'm not familiar with that feature. Do you have any sample code/configuration that shows the bad behavior?