search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Missing possibility to pass keyword arguments to protocol_factory in from_url #45

Closed dimabxsx closed 8 years ago

dimabxsx commented 9 years ago

As title says there is no way to pass extra kwargs to protocol_factory constructor when from_url is used to create connection.

dzen commented 9 years ago

Hello @dimabxsx,

can you give me some pointers on what kwargs you're giving to protocol_factory ? or a sample usage ?

Thank you

dimabxsx commented 9 years ago

I'm passing my own on_error callback to keep track of ChannelClosed exceptions. Used to auto reconnect to server is case of disconnects.

dzen commented 8 years ago

Would you please rebase your commits, add an entry in docs/changelog, and reduce the commit message lenght ? :p

thank you.

dimabxsx commented 8 years ago

Hello, @dzen,

Please review my changes.

dzen commented 8 years ago

Your commit title is still too long: try something like: from_url now passes kwargs to connect()

dzen commented 8 years ago

On master with https://github.com/Polyconseil/aioamqp/commit/dc0299447ceac9d72b6c788d6dffcf5cf92c98ac

Thank you !