search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Port to python 3.5 #50

Closed mpaolini closed 8 years ago

smurfix commented 8 years ago

It's probably too early to replace all @asyncio/coroutine/yield from pairs with async/await, py3.4 is still too wide-spread and the two schemes are mostly compatible.

However, using Python 3.5 does break some tests.

dzen commented 8 years ago

More over, I don't see python 3.5 coming on debian ( the most interesting link must be https://lists.debian.org/debian-python/2015/06/msg00036.html)

Keeping the compatibility from 3.4 to 3.5 looks like pain :(

smurfix commented 8 years ago

Python 3.5 is on Debian experimental and is able to run 3.4 code just fine. The only problem is that it exposes a nasty concurrency bug in httplib2 (used by pyrabbit) which I just submtted a pull request for.

smurfix commented 8 years ago

All tests now pass when using 3.5, at least on my machine.

AFAICT there are no plans to remove yield-from style coroutines from Python3. Thus IMHO this issue can be closed.

mpaolini commented 8 years ago

then we just need to add python 3.5 to the tox config

mpaolini commented 8 years ago

travis config I mean

smurfix commented 8 years ago

On 20.11.2015 09:36, Marco Paolini wrote:

then we just need to add python 3.5 to the tox config

Travis config updated. Thanks for noticing.

-- Matthias Urlichs

dzen commented 8 years ago

Imho the first fix should be a port of asyncio.async() to asyncio.ensure_future() ?

dzen commented 8 years ago

It seems pyrabbit is not python 3.5 compatible :(

smurfix commented 8 years ago

@dzen pyrabbit itself is perfectly 3.5 compatible. httplib2 is not. My pull request to fix this (cf. my comment from Nov 19th, above) is here: https://github.com/jcgregorio/httplib2/pull/320

dzen commented 8 years ago

yes, for sure, I didn't go deeper this weekend to know why pyrabbit fails on thoses CONNRESET :)

thank you for the patch on httplib2

dzen commented 8 years ago

Hello all,

We migrated to the git version of pyrabbit. Tests are passing.

MaxOvcharov commented 7 years ago

Hello all, At this moment, does aioamqp ported to python 3.5 syntax?

RemiCardona commented 7 years ago

No, we're still compatible with 3.4.

MaxOvcharov commented 7 years ago

Ok, thank you. Do you planning to do this?

dzen commented 7 years ago

Hi @MaxOvcharov.

We still have a lots of python 3.4 running in our production. As soon as we migrate them all, we will work on using the new syntax.