Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

fix testcase, add loop param #56

Closed smurfix closed 8 years ago

smurfix commented 8 years ago

Two changes:

dzen commented 8 years ago

Hello @smurfix ! Thank you for your PR.

Would you please add a test with a connection using another EventLoop ?

Thank you !

smurfix commented 8 years ago

Not a problem. Simply remove the code to set the event loop in testing.py and test_protocol.py, and pass self.loop wherever necessary. Any spot where the original mainloop is still used would result in a locked testcase. (Nothing that can be done about that.)

I just pushed that: 89f8a1b and also b5c362e which fixes a typo ("hearbeat"?)

smurfix commented 8 years ago

Re-testing with PYTHONASYNCIODEBUG=1

smurfix commented 8 years ago

rebased as 7821edb, should work now

rbarrois commented 8 years ago

@smurfix this looks great! However, would you mind adding a small note on this new option in the docs? Likely in the api.rst section?

Thanks :)

dzen commented 8 years ago

I'll add a new entry in the changlog section : https://github.com/Polyconseil/aioamqp/blob/master/docs/changelog.rst

smurfix commented 8 years ago

Pushed doc change(s).

dzen commented 8 years ago

Thank you ! I pushed your changes just now !