Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

add python 3.5 to travis builds #63

Closed dzen closed 8 years ago

dzen commented 8 years ago

refs #50 issue.

leth commented 8 years ago

Looking into the test failures, there seems to be some problem in pyrabbit's use of httplib2 on python 3.5. Pyrabbit master has switched to requests instead of httplib2, which should fix the problem. watch out for the small rabbitmq API url change!

dzen commented 8 years ago

hello @leth

yes exactly, but we often rely on project releases :/ I think pyrabbit probably should rely on requests since the httplib2 maintainer just give up maintaining another http lib: http://bitworking.org/news/2016/03/an_update_on_httplib2

leth commented 8 years ago

You could instead use pyrabbit from git instead of httplib2!

dzen commented 8 years ago

Got it now : Latest commit 5630e73 on Dec 24, 2015 @bkjones bkjones Replace httplib2 with requests

dzen commented 8 years ago

Seems that this pyrabbit version calls /vhosts/ instead of /api/vhosts/

digging.

leth commented 8 years ago

Yep; the string you give to pyrabbit has changed from localhost:port to localhost:port/api. I think I saw it in the readme. You might also need a trailing / on the URL, but that is probably a bug on their part.

leth commented 8 years ago

Ah you already found that!

dzen commented 8 years ago

Do you mind if I ask you to test it a little bit on python 3.5 ? I mean, if you have a larger project.

dzen commented 8 years ago

I rebase, and I'm ready to push this on master.

leth commented 8 years ago

Thanks! We're not quite ready to test things out immediately; we were just looking into our dependencies before we started. We'll get back to you when we get a chance to do so!

leth commented 8 years ago

Also: you might wish to update the classifiers in setup.py :)

dzen commented 8 years ago

I didn't updated the modifiers since I can't test if aioamqp works well with 3.5. I can't guarantee that

leth commented 8 years ago

Fair enough