Use a dict for looking up table subitem readers

Polyconseil / aioamqp

AMQP implementation using asyncio

Other

280 stars 88 forks source link

Use a dict for looking up table subitem readers #66

Closed ch3pjw closed 8 years ago

ch3pjw commented 8 years ago

This seems like a more compact and efficient way to read table subitems.

dzen commented 8 years ago

Nice point :)

ch3pjw commented 8 years ago

Is there anything outstanding on this that you want from my end?

foolswood commented 8 years ago

@dzen If the parens thing gets resolved is this ready to go?

dzen commented 8 years ago

There was nothing really important in there.

cherry-picked and pushed on master with 9e46956.

I really prefer to see a flat history.

ch3pjw commented 8 years ago

I can tell you like the flat history, it makes tracking whether my branch is merged rather a lot harder though, as github has no way of correlating your cherry-pick with this PR or my branch.