search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Readme #67

Closed ch3pjw closed 8 years ago

ch3pjw commented 8 years ago

The docker command in the readme didn't work until I removed the -v flag (there wasn't any volume information specified in the command, so docker just moaned at me with it there).

I also took the opportunity to clarify the wording of the subsequent "here's how to run the tests line".

dzen commented 8 years ago

Good point. We should tell to install developement requirements files in requirements_dev.txt:

pip install -r requirements_dev.txt. Could you please add this information in your second commit ?

Thanks.

dzen commented 8 years ago

Hello @ch3pjw,

I prefer to have those 3 commits merged, and the commit title should be prefixed by readme. For instance a commit message would be:

readme: update testing instructions

ch3pjw commented 8 years ago

I presume there's nothing left on my end preventing merge?

dzen commented 8 years ago

perfect. I will take some time friday to review the PRs we get this month, I've been busy :(

dzen commented 8 years ago

on master with 2e290d6