search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Reject incoming messages #71

Closed mastak closed 8 years ago

mastak commented 8 years ago

Why the basic_client_nack is empty? I have done in a similar way as basic_client_ack, not sure is it right.

dzen commented 8 years ago

Hello @mastak

So as basic_recover basic_recover_ok and basic_recover_async.

Would you please add some tests ?

mastak commented 8 years ago

Yes, sure.

Added one test, is it enough?

dzen commented 8 years ago

hi @mastak

I've tried to add more test in #72

Can you test it ?

mastak commented 8 years ago

As I can see, you have done this method in another branch, so pull request it is no longer relevant?

dzen commented 8 years ago

Yes exactly.

Thank you for pointing us this issue.