search

Polyconseil / aioamqp

AMQP implementation using asyncio
Other
280 stars 88 forks source link

Refactor waiter handling in channel #83

Closed foolswood closed 8 years ago

foolswood commented 8 years ago

Rough pass at tidying up waiter handling.

dzen commented 8 years ago

Are you using the no_wait argument with aioamqp ?

dzen commented 8 years ago

beware of the typo on_wait in your commit message :p

foolswood commented 8 years ago

I am not using no_wait, it was just the visual noise in the code (and the open issue) prompting a friday afternoon tidy.

dzen commented 8 years ago

Happy to know we have a few tests ;)

foolswood commented 8 years ago

I was leaning on them for this, they did their job, let's see if that fix makes things any better.

foolswood commented 8 years ago

Seems fine now, fixed the typo whilst at it.

foolswood commented 8 years ago

I believe this is ready now.

dzen commented 8 years ago

Yes, squash both commits and I'll merge it

foolswood commented 8 years ago

They're squashed.

dzen commented 8 years ago

It's merged since yesterday.