search

Polyconseil / vue-gettext

Translate your Vue.js applications with gettext.
MIT License
278 stars 55 forks source link

Safely evaluate expressions #55

Closed kevoneil closed 7 years ago

kevoneil commented 7 years ago

Hello!

When I was looking at the code a while back, I noticed that there was an eval call in the src/interpolate.js file.

MDN does not recommend eval so I thought about taking their getDescendantProp() function and tweaking it a bit. Should be a little bit more safe now and Rollup/ESLint shouldn't complain anymore.

All 73 tests pass, but please let me know if you wanted me to add some more.

Thank you!

kemar commented 7 years ago

Thanks @tokyoincode :)

kevoneil commented 7 years ago

No problem! 😄