search

Polyfrost / Hytils-Reborn

Hypixel-focused Quality of Life mod
https://modrinth.com/mod/hytils
GNU General Public License v3.0
75 stars 15 forks source link

fix: fixed AntiGL hides non-player messages #36

Closed xthe-dev closed 2 years ago

MicrocontrollersDev commented 2 years ago

(just a quick note im currently out of town on vacation) is there any reason the check for gifted messages is being removed? im not sure why it was being checked in the first place so im unsure if there was a reason it was added. if there’s no issues found then whatever.

also it’s nice that this fixes random messages from being removed (eg “opengl” would be hidden before), but it might be a bit to lenient (eg “gl everyone” or “glhf!”). might be worth a check to add .+ after maybe? (i know that these are the autogl messages but some people actually do say them themselves. though at the same time if that .+ could be seen causing other problems like the opengl thing it’s fine as is)

xthe-dev commented 2 years ago

The gifted message thing can be removed, because i replaced it with !message.contains(": ") (Check if its a player message).

The regex matcher works with find (cancelGlMessages.matcher(message).find(0)), so "gl everyone" or "glhf" is going to be hidden. (everything is tested btw)

MicrocontrollersDev commented 2 years ago

ah im stupid and missed that. in that case it looks fine and i’ll merge in a bit