search

Polyfrost / Hytils-Reborn

Hypixel-focused Quality of Life mod
https://modrinth.com/mod/hytils
GNU General Public License v3.0
75 stars 15 forks source link

move some patterns to LanguageData #51

Closed MicrocontrollersDev closed 1 year ago

MicrocontrollersDev commented 1 year ago

Description

Move regexes to LanguageData. Will require an accompanying DataStorage PR and I'll do that after I make sure there's nothing else I should move over and to make sure this actually works because idk how DataStorage works 👍

How to test

Turn on an affected feature and see if it works or not (once DataStorage pr is merged)

Release Notes

Move some regexes to LanguageData, allowing for updates without needing to release a new version of Hytils
MicrocontrollersDev commented 1 year ago

@SirXThe thanks for the DataStorage commit, I don't think there's anything else that really needs to be moved over. There are a few messages that could but really don't need to since I doubt they'll ever change and are super small so I'm leaving them as is. This PR is ready for merge or a review or whatever.

Wyvest commented 1 year ago

@SirXThe thanks for the DataStorage commit, I don't think there's anything else that really needs to be moved over. There are a few messages that could but really don't need to since I doubt they'll ever change and are super small so I'm leaving them as is. This PR is ready for merge or a review or whatever.

Looks fine rn, will wait for DataStorage PR though

MicrocontrollersDev commented 1 year ago

closing in favor of #53