added the option to specify categories and subcategories with the @Category and @SubCategory annotations.

Polyfrost / OneConfig

Next generation configuration library for Minecraft

https://polyfrost.org/projects/oneconfig

Other

232 stars 24 forks source link

added the option to specify categories and subcategories with the @Category and @SubCategory annotations. #292

Closed urisinger closed 7 months ago

urisinger commented 10 months ago

Description

This allows mod developers to better organize their code by creating a diffrent class for each category/subcategory of options they have, this also allows the devolper to create custom categories. This will not effect the current api, which can still be used.

Documentation

This feature adds 2 new annotions, @Category and @SubCategory, Which both need to be documanted.

Checklist

[x] I made a clear description of what was changed
[x] I stated why these changes were necessary
[x] I updated documentation or said what needs to be updated
[x] I made sure these changes are backwards compatible
[x] This pull request is for one feature/bug fix

urisinger commented 10 months ago

it looks good, just not 100% sure of the rationale behind this change and a couple formatting/api status nitpicks.

In my opinion this way of specifying categories is much better, and leads to less confusing varible names. Also wyvest said it would be better, so how could it not?

Wyvest commented 9 months ago

Sorry for the delayed responses from Polyfrost - we've all been going through IRL stuff like school and other related activities

can you run the apiDump gradle command? That should generate the new ABI with changes made in this PR.

urisinger commented 9 months ago

I have a problem with running mc in the devolpment environment, so i cant test these changes right now, but this should work and reduce some code duplication

urisinger commented 7 months ago

Stopped working on this since 1.0 is releasing, I hope that 1.0 won't also have this problem