search

PolyglotSymposium / void

A fearless modern text editor in the spirit of Vim
MIT License
3 stars 1 forks source link

Sketched out a vertical slice of VoidScript and command mode #26

Closed Kazark closed 9 years ago

Kazark commented 9 years ago

This is quite preliminary and there is much left to do. For example, even though a few command mode commands actually work (e.g. ;q), they do not display on the screen. Also, generally I only covered the happy-path cases; there is much edge-case support left do to, etc.

Unrelated to VoidScript, though needed for this implementation, I introduced the concept of requests as well as a decoupled way of talking to another service when a response is needed.

This resolves #9.

@mjgpy3 You don't have to review this if you don't want to. Let me know if you just want me to merge it. I even renamed the Void directory to src, so who knows how the diff will even come out on GitHub! (You should be able to view it fine locally using --find-renames.)

Kazark commented 9 years ago

It's still saying the you can't automerge, but actually no merge is needed; you can just take the version of the conflicted file from this pull request because I pushed up a resolution.

Kazark commented 9 years ago

I'm actually going to update this further. I realized there was a section I marked to refactor and that is leading me down a little bit different path.