CZ4 - Landing Page Skeleton

Polygon-Solutions / city-keep

CityKeep - Civic Issue Reporting App

https://www.citykeep.app

MIT License

0 stars 1 forks source link

CZ4 - Landing Page Skeleton #5

Closed malakivandas closed 2 years ago

malakivandas commented 2 years ago

Commit 1e22556 (Private Outlet)

The private outlet only displays the Navbar and either the Reports or Settings pages if the user is authenticated.
When not authenticated, the user can only access the Login and Register pages.
(The mock user authentication is temporarily governed by a variable set to true or false in App.jsx)

malakivandas commented 2 years ago

@BraidenCutforth Please review the most recent commit 20e721f. Do you think the TabPanel component should move into its own file?

After that, I'll do some clean up then I should be ready to close this pull request.

malakivandas commented 2 years ago

Hold on, in a wrestling match with git

malakivandas commented 2 years ago

Ok good to go

malakivandas commented 2 years ago

Lol oops

Good thing it's only me working on this

BraidenCutforth commented 2 years ago

@BraidenCutforth Please review the most recent commit 20e721f. Do you think the TabPanel component should move into its own file?

After that, I'll do some clean up then I should be ready to close this pull request.

I am thinking that it is okay to keep it in this file because my guess is it is only relevant here. That being said you could make a tab page component that is general, where you pass in info for the tabs and the list of the different tab panel contents.