search

Polygon-Solutions / city-keep

CityKeep - Civic Issue Reporting App
https://www.citykeep.app
MIT License
0 stars 1 forks source link

CK6 - WorkInProgress (WIP) Tooltip (cont.) #8

Closed malakivandas closed 2 years ago

malakivandas commented 2 years ago

Continuing from the accidentally closed pull request (#6)

malakivandas commented 2 years ago

Ngl I am impressed with this fix 85ab516. With the Chrome and React plugin devtools, I used the Elements tab and the Components tab to figure out that the Tooltip component was not rendering a DOM element wrapped around the floating action button (FAB) and was instead just creating an event listener. (@BraidenCutforth I think you suspected this and that's why you suggested to remove the Box MUI component in the previous commit 1d29089.) Anyways, now it just positions the FAB as it did before with the const StyledFab = styled(Fab) and all is well.

malakivandas commented 2 years ago

I'm satisfied for now and need to move on so I've merged this branch into main. I created Issue #9 for a different WIP tooltip to be made for the 'Remember Me' feature.

I'll keep this PR open for now for if @BraidenCutforth has any comments on the last couple commits I made (85ab516, 3373df4, 0c68ce6)