PolyhedralDev / Terra

Voxel world generation modding platform
MIT License
645 stars 87 forks source link

[Feature] Provide translation for Terra biomes #311

Open ardissaps opened 2 years ago

ardissaps commented 2 years ago

Biome IDs currently do not have any provided translations, leading to Biome.<ID> being used as a default placeholder

dfsek commented 2 years ago

Biome IDs are supposed to be unique identifiers. If you want a mapping of identifier to human-readable name, you can use the API.

ardissaps commented 2 years ago

Biome IDs are supposed to be unique identifiers. If you want a mapping of identifier to human-readable name, you can use the API.

Ok, I guess the mod is only for developer right now as I am sure not all player can do what you suggest, but anyway thx for making the mod.

dfsek commented 2 years ago

If we made biome IDs terra:plains, we would run into conflicts when multiple config packs are installed. The IDs need to be unique, if you have a shorter way to map pack + biome IDs to Minecraft biome IDs in a unique manner, you can suggest it.

duplexsystem commented 2 years ago

Actually I see their issue here. As opposed to vanilla, we don't include any translations for our biomes. Managing this server side is tricky but it's probably something we should took into

dfsek commented 2 years ago

ah, they mean translation rather than ID

duplexsystem commented 2 years ago

this is a good reference on how to implement this server side: https://github.com/NucleoidMC/Server-Translations

astrsh commented 2 years ago

Leaving this here https://fabricmc.net/wiki/tutorial:lang

astrsh commented 2 years ago

I think human readable names should be specified somewhere within each biome config, perhaps by specifying a mapping from language to name - would require being able to update translations during runtime