PolyhedralDev / Terra

Voxel world generation modding platform
MIT License
642 stars 85 forks source link

Add option to not salt cellular lookup #372

Closed Astrashh closed 1 year ago

Astrashh commented 1 year ago

Pull Request

Licensing

Goal of the PR

Allows lookup samplers to not be affected by the cellular sampler's salt

Affects of the PR

Only affects behavior if salting is explicitly turned off by setting salt-lookup to false

Types of changes

Compatiblity

Contribution Guidelines.

Documentation

Testing

duplexsystem commented 1 year ago

I think it would be better to instead have an option for lookup salt where the default is the existing salt

Astrashh commented 1 year ago

the lookup can be independently salted like any other sampler, eg:

type: CELLULAR
return: NoiseLookup
salt: 3
salt-lookup: true # default
lookup:
  type: OPEN_SIMPLEX_2 # Is actually salted as 3 + 6
  salt: 6
type: CELLULAR
return: NoiseLookup
salt: 3
salt-lookup: false
lookup:
  type: OPEN_SIMPLEX_2 # Is salted as 6
  salt: 6
duplexsystem commented 1 year ago

hmm ok

duplexsystem commented 1 year ago

@dfsek are you against merging this?