PolyhedralDev / Terra

Voxel world generation modding platform
MIT License
642 stars 85 forks source link

[Bug] Custom Biome Colors in 1.19.3 #388

Closed justaureus closed 11 months ago

justaureus commented 1 year ago

Pre-Issue Checklist

Environment

Name Value
Terra Version 6.2.2
Platform / Platform Version Purpur 1.19.3
Any External Plugins or Mods N/A
Terra Packs In Use Default
Terra Addons In Use Default

Issue Description

When using NMS-based configuration options (e.g, biome colors), there is a bug on world creation.

Steps to reproduce

Creating a world with a pack using custom biome colors

  1. Use custom sky/fog/water/etc biome colors
  2. Generate world using pack with said custom colors
  3. Review latest.log for error, as the world will still generate however will lack Terra generation

Expected behavior

A world should generate with custom biome colors

Actual behavior

World generates as a vanilla world without Terra generation

Full stacktrace

Exception Stacktrace [21:19:45] [Server thread/ERROR]: Could not pass event WorldInitEvent to Terra v6.2.2-BETA+8fff27fdd java.lang.IllegalArgumentException: No properties registered for class com.dfsek.terra.bukkit.nms.v1_19_R2.NMSBiomeInfo at com.dfsek.terra.api.properties.Context.lambda$get$1(Context.java:30) ~[Terra-bukkit-6.2.2-BETA+8fff27fdd-shaded.jar:?] at java.util.HashMap.computeIfAbsent(HashMap.java:1220) ~[?:?] at com.dfsek.terra.api.properties.Context.get(Context.java:29) ~[Terra-bukkit-6.2.2-BETA+8fff27fdd-shaded.jar:?] at com.dfsek.terra.bukkit.nms.v1_19_R2.NMSBiomeProvider.lambda$new$0(NMSBiomeProvider.java:24) ~[Terra-bukkit-6.2.2-BETA+8fff27fdd-shaded.jar:?] at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?] at java.util.Collections$2.tryAdvance(Collections.java:4853) ~[?:?] at java.util.Collections$2.forEachRemaining(Collections.java:4861) ~[?:?] at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?] at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?] at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575) ~[?:?] at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260) ~[?:?] at java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:616) ~[?:?] at java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:622) ~[?:?] at java.util.stream.ReferencePipeline.toList(ReferencePipeline.java:627) ~[?:?] at net.minecraft.world.level.biome.BiomeSource.(BiomeSource.java:29) ~[?:?] at com.dfsek.terra.bukkit.nms.v1_19_R2.NMSBiomeProvider.(NMSBiomeProvider.java:21) ~[Terra-bukkit-6.2.2-BETA+8fff27fdd-shaded.jar:?] at com.dfsek.terra.bukkit.nms.v1_19_R2.NMSInjectListener.onWorldInit(NMSInjectListener.java:39) ~[Terra-bukkit-6.2.2-BETA+8fff27fdd-shaded.jar:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor1.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:git-Purpur-1880] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:680) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?] at net.minecraft.server.MinecraftServer.initWorld(MinecraftServer.java:657) ~[purpur-1.19.3.jar:git-Purpur-1880] at org.bukkit.craftbukkit.v1_19_R2.CraftServer.createWorld(CraftServer.java:1333) ~[purpur-1.19.3.jar:git-Purpur-1880] at org.bukkit.Bukkit.createWorld(Bukkit.java:782) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?] at org.bukkit.WorldCreator.createWorld(WorldCreator.java:474) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?] at com.onarandombox.MultiverseCore.utils.WorldManager.doLoad(WorldManager.java:486) ~[Multiverse-Core-4.3.1.jar:?] at com.onarandombox.MultiverseCore.utils.WorldManager.addWorld(WorldManager.java:288) ~[Multiverse-Core-4.3.1.jar:?] at com.onarandombox.MultiverseCore.commands.CreateCommand.runCommand(CreateCommand.java:125) ~[Multiverse-Core-4.3.1.jar:?] at com.onarandombox.commandhandler.CommandHandler.checkAndRunCommand(CommandHandler.java:296) ~[Multiverse-Core-4.3.1.jar:?] at com.onarandombox.commandhandler.CommandHandler.processFoundCommands(CommandHandler.java:143) ~[Multiverse-Core-4.3.1.jar:?] at com.onarandombox.commandhandler.CommandHandler.locateAndRunCommand(CommandHandler.java:93) ~[Multiverse-Core-4.3.1.jar:?] at com.onarandombox.MultiverseCore.MultiverseCore.onCommand(MultiverseCore.java:839) ~[Multiverse-Core-4.3.1.jar:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:168) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_19_R2.CraftServer.dispatchCommand(CraftServer.java:975) ~[purpur-1.19.3.jar:git-Purpur-1880] at org.bukkit.craftbukkit.v1_19_R2.command.BukkitCommandWrapper.run(BukkitCommandWrapper.java:64) ~[purpur-1.19.3.jar:git-Purpur-1880] at com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:264) ~[purpur-1.19.3.jar:?] at net.minecraft.commands.Commands.performCommand(Commands.java:321) ~[?:?] at net.minecraft.commands.Commands.performCommand(Commands.java:305) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.performChatCommand(ServerGamePacketListenerImpl.java:2379) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$21(ServerGamePacketListenerImpl.java:2339) ~[?:?] at net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:59) ~[?:?] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[purpur-1.19.3.jar:git-Purpur-1880] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1368) ~[purpur-1.19.3.jar:git-Purpur-1880] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:197) ~[purpur-1.19.3.jar:git-Purpur-1880] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1345) ~[purpur-1.19.3.jar:git-Purpur-1880] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1338) ~[purpur-1.19.3.jar:git-Purpur-1880] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1316) ~[purpur-1.19.3.jar:git-Purpur-1880] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1204) ~[purpur-1.19.3.jar:git-Purpur-1880] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:321) ~[purpur-1.19.3.jar:git-Purpur-1880] at java.lang.Thread.run(Thread.java:833) ~[?:?] ``` ```

Additional details