Port to Folia

[pontaoski]

Pull Request

Brief description.

This adds Folia compatibility.

What Issues Does This Fix?

Fix #397

Licensing

• [x] I am the original author of this code, and I am willing to release it under GPLv3.
• [ ] I am not the original author of this code, but it is in public domain or released under GPLv3 or a compatible license.

Goal of the PR

• [x] Port to Folia

Affects of the PR

Types of changes

• [ ] Bug Fix
• [x] Build system
• [ ] Documentation
• [x] New Feature
• [ ] Performance
• [x] Refactoring
• [ ] Repository
• [ ] Revert
• [ ] Style
• [ ] Tests
• [ ] Translation

Compatiblity

• [ ] Breaking change
• [x] Non-Breaking change.

Contribution Guidelines.

• [x] I have read the CONTRIBUTING.md document in the root of the git repository.
• [x] My code follows the code style for this project.

[pontaoski]

seems to be working? :3

[solonovamax]

should the folia port be a separate submodule/platform?

and, why is the 1.19_r1 nms not being shaded?

[pontaoski]

folia is 99% the same code, so the usual way to port is to just switch the API package to folia and guard folia APIs behind version checks

also oops that was failing to build locally so i commented it out

[solonovamax]

I opened an issue on run-task (jpenilla/run-task#31) requesting a plugin be added with folia support.

The reason I say it might warrant being a separate module is because it would allow as to remove the version checks, and then also being able to run a folia server to test during dev.

if it were a separate module, it would be best to somehow commonize the paper module so that the paper & folia modules have very few lines of code.

[solonovamax]

nvm, run-paper already has folia support. run-paper should be updated to the latest version, 1.1.0

[solonovamax]

we should attempt to have 1.19_r1 shaded again

[solonovamax]

also, idk about setting the folia dep to 1.20. that means that we could accidentally introduce changes that would prevent it from running on 1.18 bukkit.

[pontaoski]

folia doesn't come in a 1.18 API flavour

[solonovamax]

yes I know. which is another reason for having both a folia and a bukkit platform.

[justaureus]

also, idk about setting the folia dep to 1.20. that means that we could accidentally introduce changes that would prevent it from running on 1.18 bukkit.

We don't support 1.18 bukkit anymore, only 1.19/1.20.

[solonovamax]

We don't support 1.18 bukkit anymore, only 1.19/1.20.

ah, I see

however, it'd still (possibly) break on 1.19

[duplexsystem]

Superseded by #417