PolyhedralDev / Terra

Voxel world generation modding platform
MIT License
638 stars 83 forks source link

[Bug] Feature Changes Do Not Take Effect With /terra:packs reload #457

Open ydal251 opened 3 months ago

ydal251 commented 3 months ago

Environment

| Terra Version | 6.4.3
| Platform / Platform Version | Purpur-2134 | Any External Plugins or Mods | Spark, WorldEdit
| Terra Packs In Use | Overworld, Modified Overworld, Substratum, Modified Substratum (Active Pack) | Terra Addons In Use | library-image@1.1.0-BETA+ab60f14ff generation-stage-structure@1.0.0-BETA+ab60f14ff command-structures@1.0.0-BETA+ab60f14ff terra@1.0.0 config-locators@1.1.1-BETA+ab60f14ff palette-block-shortcut@1.0.0-BETA+ab60f14ff command-profiler@1.0.0-BETA+ab60f14ff language-yaml@1.0.0-BETA+ab60f14ff biome-query-api@1.0.0-BETA+ab60f14ff biome-provider-pipeline@1.0.2-BETA+ab60f14ff terra-bukkit@1.0.0 biome-provider-image-v2@1.0.1-BETA+ab60f14ff biome-provider-single@1.0.0-BETA+ab60f14ff config-number-predicate@1.0.0-BETA+ab60f14ff locator-slant-noise-3d@1.0.0-BETA+ab60f14ff config-distributors@1.0.1-BETA+ab60f14ff structure-sponge-loader@1.0.0-BETA+ab60f14ff structure-block-shortcut@1.0.0-BETA+ab60f14ff config-noise-function@1.1.0-BETA+ab60f14ff terrascript-function-sampler@1.0.0-BETA+ab60f14ff config-ore@1.1.1-BETA+ab60f14ff command-addons@1.0.0-BETA+ab60f14ff pipeline-image@1.0.0-BETA+ab60f14ff config-feature@1.0.0-BETA+ab60f14ff chunk-generator-noise-3d@1.2.1-BETA+ab60f14ff biome-provider-extrusion@1.0.0-BETA+ab60f14ff biome-provider-pipeline-v2@1.0.1-BETA+ab60f14ff config-palette@1.0.0-BETA+ab60f14ff generation-stage-feature@1.1.0-BETA+ab60f14ff structure-mutator@0.1.0-BETA+ab60f14ff biome-provider-image@1.0.1-BETA+ab60f14ff structure-function-check-noise-3d@1.0.1-BETA+ab60f14ff config-flora@1.0.1-BETA+ab60f14ff config-structure@1.0.1-BETA+ab60f14ff command-packs@1.0.0-BETA+ab60f14ff

Issue Description

Features used as preprocessors (Such as in the lush_cave_water_pools) do not update changes on a /terra:packs reload There are no errors on pack reload, and the changes do work as expected after server restart

Steps to reproduce

  1. Generate chunks containing the feature you're editing

  2. Make and save config changes such as: structures: distribution: type: CONSTANT structures: BLOCK:minecraft:diamond_block

    To:

structures: distribution: type: CONSTANT structures: BLOCK:minecraft:emerald_block

  1. Run /terra:packs reload and wait for conformation Terra reloaded successfully

  2. Teleport 10000 blocks to new chunks

  3. The changes have not applied to new generation

  4. Restart server

  5. Teleport 10000 blocks again to new chunks

  6. Changes to generation are applied now

Expected behavior

As described in the Wiki (https://terra.polydev.org/config/development/introduction.html#reloading) and for most changes a restart is not needed to make generation changes

Actual behavior

Generation changes made to Features used in Preprocessors do not take effect without a server restart

Full stacktrace

No errors, logs attached latest.log

Additional details

N/A