Polymer / hn-polymer-2

Polymer Hacker News clone
158 stars 23 forks source link

Fix link to item when domain is null #12

Open rubenochiavone opened 6 years ago

rubenochiavone commented 6 years ago

When a list item doesn't have a domain the anchor element gets an invalid URL (probably server side API changed?). But it is possible to create a valid URL for that item using "/item/" + item.id.

I've also removed empty parentheses from title using item domain property.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


rubenochiavone commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!